-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript][angular] basePath through injected config #289
Closed
akehir
wants to merge
53
commits into
OpenAPITools:master
from
akehir:feature/basePathThroughInjectedConfig
Closed
Changes from 3 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
ec8c581
#282: Use injected configuration to refer to basePath
akehir 03939c8
Regenerate tests with new api templates
akehir 9930f61
Ignore signing for other branches than master (#288)
jmini 2ff81ca
Expanding customization docs (#283)
55f9e31
Update template modification docs (#291)
jimschubert ff94464
Updated api to always use configuration even if old http client is us…
akehir 2995273
[go-server] Add dockerfile for building and run petstore service (#274)
etherealjoy 49b8ece
update cpp server scripts/batch files (#296)
wing328 6f6a4a1
[rust-server] (Re-)Adding support for rust-server (#290)
bjgill f964873
Change "samples" profile name to "samples.shippable" (#305)
jmini 91d6d77
[rust-server] Add rust-server to travis CI (#308)
bjgill 7126074
add Go client test - TestPlaceOrder (#321)
grokify 24104da
Add option modelPropertyNaming to javascript generator (#299)
stianlik f8e61ac
[typescript] fix cast problem (#303)
topce 680a2bc
Configuration option to disable HTML escaping when using Gson (#298)
stianlik 5630746
Remove "CI/pom.xml.shippable" (#319)
jmini 6c996a7
Various improvement to CI (#326)
wing328 e5635d2
update brew readme (#330)
wing328 798bf61
Grammar and spelling fixes (#329)
scop 53d9878
Update Petstore samples (#331)
wing328 c607ea8
Add fixes for es6 generator (#180)
delenius 7c49bdd
CircleCI migration from 1.0 to 2.0 (#333)
wing328 75171b4
[C++] Rename template dir (#332)
ackintosh 97bab92
[cli] Enable recommendations on validate command (#292)
jimschubert c51986d
Go server clean up (#328)
bvwells 30d1021
Add links for released versions in compat table (#336)
grokify 74914b6
Prepare release 3.0.2 (#337)
jmini 9511586
Prepare 3.0.3-SNAPSHOT (#338)
jmini 1ffc4a2
Moved Typescript Angular 6 builds into 'builds' subdirectory to confo…
akehir 9151f65
Adding in Telstra (#357)
developersteve 231202d
Initial roadmap (#295)
jimschubert 3c9cf1d
Restore unit test (#346)
jmini d19a2fa
[php] Correctly handle multiple valid responses (#128)
fMads 645a25b
Added angular 6 with-npm sample client
akehir 108aabc
Add test cases for angular 6 generated sample client, as well as for …
akehir 35fbac1
Fixed typos in typescript pom.xml
akehir 9993684
Add no-watch to karma
akehir d4654fc
Use PhantomJS instead of Chrome, rename all typescript-angular-poms t…
akehir d5b209d
#282: Use injected configuration to refer to basePath
akehir 63326b8
Regenerate tests with new api templates
akehir ddab13c
Updated api to always use configuration even if old http client is us…
akehir dc74492
Moved Typescript Angular 6 builds into 'builds' subdirectory to confo…
akehir 6ec5160
Added angular 6 with-npm sample client
akehir d4d23d2
Add test cases for angular 6 generated sample client, as well as for …
akehir 7cb71ab
Fixed typos in typescript pom.xml
akehir 2353fe7
Add no-watch to karma
akehir 802a42b
Use PhantomJS instead of Chrome, rename all typescript-angular-poms t…
akehir ea59f19
Merge branch 'feature/basePathThroughInjectedConfig' of github.com:ak…
akehir 871445a
Enable angular 6 test cases in circleci
akehir dc880e8
Use nvm to update node
akehir 6beb630
Do not show angular build progress as it spams the ci log
akehir c983865
Do not duplicate addons in travis
akehir dcb3d12
Run Chrome in headless mode for CI
akehir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
bin/typescript-angular-v6-petstore-not-provided-in-root.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
#!/bin/sh | ||
|
||
SCRIPT="$0" | ||
echo "# START SCRIPT: $SCRIPT" | ||
|
||
while [ -h "$SCRIPT" ] ; do | ||
ls=`ls -ld "$SCRIPT"` | ||
link=`expr "$ls" : '.*-> \(.*\)$'` | ||
if expr "$link" : '/.*' > /dev/null; then | ||
SCRIPT="$link" | ||
else | ||
SCRIPT=`dirname "$SCRIPT"`/"$link" | ||
fi | ||
done | ||
|
||
if [ ! -d "${APP_DIR}" ]; then | ||
APP_DIR=`dirname "$SCRIPT"`/.. | ||
APP_DIR=`cd "${APP_DIR}"; pwd` | ||
fi | ||
|
||
executable="./modules/openapi-generator-cli/target/openapi-generator-cli.jar" | ||
|
||
if [ ! -f "$executable" ] | ||
then | ||
mvn -B clean package | ||
fi | ||
|
||
# if you've executed sbt assembly previously it will use that instead. | ||
export JAVA_OPTS="${JAVA_OPTS} -XX:MaxPermSize=256M -Xmx1024M -DloggerPath=conf/log4j.properties" | ||
ags="generate -i modules/openapi-generator/src/test\resources/2_0/petstore.yaml -l typescript-angular -o samples/client/petstore/typescript-angular-v6-not-provided-in-root/default -D providedInRoot=false --additional-properties ngVersion=6.0.0 $@" | ||
|
||
java $JAVA_OPTS -jar $executable $ags |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
#!/bin/sh | ||
|
||
SCRIPT="$0" | ||
echo "# START SCRIPT: $SCRIPT" | ||
|
||
while [ -h "$SCRIPT" ] ; do | ||
ls=`ls -ld "$SCRIPT"` | ||
link=`expr "$ls" : '.*-> \(.*\)$'` | ||
if expr "$link" : '/.*' > /dev/null; then | ||
SCRIPT="$link" | ||
else | ||
SCRIPT=`dirname "$SCRIPT"`/"$link" | ||
fi | ||
done | ||
|
||
if [ ! -d "${APP_DIR}" ]; then | ||
APP_DIR=`dirname "$SCRIPT"`/.. | ||
APP_DIR=`cd "${APP_DIR}"; pwd` | ||
fi | ||
|
||
executable="./modules/openapi-generator-cli/target/openapi-generator-cli.jar" | ||
|
||
if [ ! -f "$executable" ] | ||
then | ||
mvn -B clean package | ||
fi | ||
|
||
# if you've executed sbt assembly previously it will use that instead. | ||
export JAVA_OPTS="${JAVA_OPTS} -XX:MaxPermSize=256M -Xmx1024M -DloggerPath=conf/log4j.properties" | ||
ags="generate -i modules/openapi-generator/src/test/resources/2_0/petstore.yaml -l typescript-angular -o samples/client/petstore/typescript-angular-v6-provided-in-root/default --additional-properties ngVersion=6.0.0 $@" | ||
|
||
java $JAVA_OPTS -jar $executable $ags |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
samples/client/petstore/typescript-angular-v2/default/.openapi-generator/VERSION
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.0.1-SNAPSHOT | ||
3.0.2-SNAPSHOT |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
samples/client/petstore/typescript-angular-v2/npm/.openapi-generator/VERSION
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.0.1-SNAPSHOT | ||
3.0.2-SNAPSHOT |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't you want to set
in order to account for the situation where you pass a
configuration
object that does not contain a base path plus abasePath
parameter, since thebasePath
property ofConfiguration
is optional, seehttps://github.com/openapitools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/typescript-angular/configuration.mustache#L15
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would even mark the
basePath
property of the api service as deprecated, since onlythis.configuration.basePath
should be used. what do you think about that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now