[Java] Fix numeric field names #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fjolnir-Dvorak
changed the title
macjohnny
approved these changes
Jul 24, 2019
| @@ -585,6 +585,11 @@ public String toVarName(String name) { | |||
| name = "_u"; | |||
| } | |||
|
|
|||
| // numbers are not allowed at the beginning | |||
| if (name.matches("^\\d.*")) { | |||
There was a problem hiding this comment.
I guess this is needed here, in addition to
if the name is all uppercase and thus matches this early return:
pe-st
suggested changes
Jul 24, 2019
|
I will look into the tests tomorrow |
…haviour for future breaking changes OpenAPITools#3293.
…ing changes in the future. OpenAPITools#3293.
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nerators are escaped now.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Somehow the generator started somewhen to generate broken java code if the fields in the openapi spec are staring with a number. Numbers are not allowed at the start of a word in java so they need to be escaped. This bugfix escapes all varNames which start with a number with an underscore like it was sometime before
Fixed Issues:
Technical Commitee for Java:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)