Manage enum properly on Dart Jaguar generator #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaumard
commented
Aug 15, 2019
| final DateTime shipDate; | ||
| /* Order Status */ | ||
| @Alias('status', isNullable: false) | ||
| @Alias('status', isNullable: false, | ||
| processor: const StringFieldProcessor(), |
There was a problem hiding this comment.
@wing328 is there a way to know if the enum is from and #ref or inline ? Because this will not work :/
#ref enum are generating a new file and class, but inline are not for some reason and does this instead
There was a problem hiding this comment.
I have ignored inline enum and handle them as simple string, I don't think their is another easy way to do that for now, at least the compiled code works like this
jaumard
force-pushed
the
bugfix/jaguarEnumSupport
branch
from
61dc532
to
f7cd17e
Compare
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum where not generate properly at all, now should be ok