Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regexp fails on Windows because of backslashes in the path #3802

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

ian7
Copy link
Contributor

@ian7 ian7 commented Aug 29, 2019

PR checklist

  • [ x] Read the contribution guidelines.
  • [x ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • [x ] Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • [ x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix regexp fails on Windows becuase of backslashes in the path #3802

@wing328 wing328 merged commit e39b420 into OpenAPITools:master Aug 30, 2019
@wing328 wing328 changed the title no need to use regex for this replacement - regexp fails on windows b… Fix regexp fails on Windows becuase of backslashes in the path Aug 30, 2019
@wing328 wing328 added this to the 4.1.2 milestone Aug 30, 2019
@wing328 wing328 changed the title Fix regexp fails on Windows becuase of backslashes in the path Fix regexp fails on Windows because of backslashes in the path Aug 30, 2019
@wing328
Copy link
Member

wing328 commented Aug 30, 2019

@ian7 thanks for the fix, which has been merged into master.

I've also added tests via #3805 to cover this issue moving forward

@wing328
Copy link
Member

wing328 commented Sep 12, 2019

@ian7 thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants