Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Remove unnecessary IF statement #421

Merged
merged 2 commits into from
Jun 30, 2018

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Jun 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Checking if JSON_PRETTY_PRINT is defined is unnecessary as the generated PHP client supports PHP >= 5.5 and JSON_PRETTY_PRINT is available since PHP 5.4.0.

JSON_PRETTY_PRINT is available since PHP 5.4.0
- bin/php-petstore.sh
- bin/security/php-petstore.sh
- bin/openapi3/php-petstore.sh
@ackintosh ackintosh added this to the 3.1.0 milestone Jun 30, 2018
@ackintosh
Copy link
Contributor Author

TechnicalCommittee: @jebentier (2017/07) @dkarlovi (2017/07) @mandrean (2017/08) @jfastnacht (2017/09)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as JSON_PRETTY_PRINT is for PHP 5.4+ and we only support PHP 5.5+ for the client.

Ref: http://php.net/manual/en/json.constants.php

@ackintosh ackintosh merged commit 8e648e4 into OpenAPITools:master Jun 30, 2018
@ackintosh ackintosh deleted the remove-unused-if-statement branch June 30, 2018 11:30
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Delete unused IF statement

JSON_PRETTY_PRINT is available since PHP 5.4.0

* Update samples

- bin/php-petstore.sh
- bin/security/php-petstore.sh
- bin/openapi3/php-petstore.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants