[java-jaxrs] Fix paths when useTags=true is used #437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.1.x
,4.0.x
. Default:master
.Java: @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)
Description of the PR
Detected during test of #215.
When you use the
useTags
boolean option with thejaxrs-jersey
generator, there is a problem with the paths.Example spec: tags.yaml (added to this PR as test case)
Then the endpoints are:
They are driven by the tags (and tags name).
They should be as specified in the
paths
section:This PR introduces a new variable accessible in the JaxRS templates:
{{commonPath}}
.This is because the
{{baseName}}
when tags are used can not be used in the top level@Path
annotation value.{{commonPath}}
contains the path common to all operations of the generated groups.A unit test to ensure that nothing was changed cases where
useTags
is set tofalse
(default behavior) is also added to the PR.