Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move online gen from jersey to spring boot #44

Merged
merged 1 commit into from
May 15, 2018

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented May 15, 2018

Move the online codegen from jersey to spring boot
The stub was generated with openapi-generator from the existing openAPI def. Some little things still needed to be done by hand.
Command line used:

java -jar ../../modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -l spring -i /tmp/swagger.json --group-id org.openapitools --artifact-id openapi-generator-online -DhideGenerationTimestamp=true,delegatePattern=true

I need to do some polishing:

  • Swagger ui description, remove references to swagger
  • Cleaning ot the OAS def generated by Springfox (esp. "spec", JsonNode, File, Resource, URI, ...)
  • Context path / API serving tuning
  • Dockerfile
  • Integrate the maven plugin to generate the endpoints from an OAS file (interfaceOnly)
  • Other ?

@OpenAPITools/openapi-generator-core-team Can you test and give your feedback ?

@cbornet
Copy link
Member Author

cbornet commented May 15, 2018

Removing 500+ lines of code 😎

@cbornet
Copy link
Member Author

cbornet commented May 15, 2018

Note: the error response body have changed and are now the standard ones from Spring Boot. I believe that it's not a big issue since most clients should only use the Http status code.

@wing328
Copy link
Member

wing328 commented May 15, 2018

@cbornet thanks. Let me test it out.

@wing328
Copy link
Member

wing328 commented May 15, 2018

Did some tests and worked as expected. I'll add the Dockerfile in a separate PR.

@wing328 wing328 changed the title [WIP] Move online gen from jersey to spring boot Move online gen from jersey to spring boot May 15, 2018
@wing328 wing328 added this to the 3.0.0 milestone May 15, 2018
@wing328 wing328 merged commit 8dd46a3 into OpenAPITools:master May 15, 2018
@cbornet cbornet deleted the spring-online-gen branch May 15, 2018 20:42
aserkes added a commit to aserkes/openapi-generator that referenced this pull request Aug 22, 2022
Ghufz pushed a commit to Ghufz/openapi-generator that referenced this pull request Jun 8, 2023
pull in golang restrict read-only props changes from upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants