Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust Server] Support complex query parameters #5831

Merged
merged 6 commits into from
Apr 12, 2020
Merged

[Rust Server] Support complex query parameters #5831

merged 6 commits into from
Apr 12, 2020

Conversation

richardwhiuk
Copy link
Contributor

Support complex query parameters by using the correct FromStr implementation and using ToString at all.

This enables support for definitions such as:

      parameters:
        - name: list-of-strings
          in: query
          schema:
            type: array
            items:
              $ref: '#/components/schemas/StringObject'

This fix was contributed by @mirw and reviewed by myself on behalf of @Metaswitch.

Rust Server Technical Committee

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants