Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Remove platform dependency from file path #610

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

ackintosh
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes #585

@jmini jmini merged commit af9d57e into OpenAPITools:master Jul 20, 2018
@jmini
Copy link
Member

jmini commented Jul 20, 2018

Thank you a lot for this PR.

@jmini jmini added this to the 3.1.2 milestone Jul 20, 2018
@ackintosh ackintosh deleted the remove-platform-dependency branch July 21, 2018 01:24
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path in phpunit.xml.dist is platform dependent
3 participants