Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[php-symfony] Set required PHP version ^7.1.3 #6181

Merged
merged 11 commits into from
May 29, 2020
Merged

[php-symfony] Set required PHP version ^7.1.3 #6181

merged 11 commits into from
May 29, 2020

Commits on May 8, 2020

  1. Set PHP 7.1.3 required version 

    I've tried to specify ^7.0 version at first, but main package which is
symfony/[email protected] requires PHP ^7.1.3.
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    6bbd343 View commit details
    Browse the repository at this point in the history

  2. Bump Symfony FrameworkBundle to ^4.4.8 

    Current Symfony Framework stable version is v5.0.8, but I guess it
requires significant codebase upgrade, so I've sticked with 4.4.8 which
shouldn't cause any breaking changes. Old requirement was ^3.3|^4.1
which compatible with 4.4.8.
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    7174337 View commit details
    Browse the repository at this point in the history

  3. Bump PHPUnit version to ^7.0 

    PHPUnit 8.x version required PHP ^7.2, so I'm setting 7.x version to
support PHP 7.1.
There is new way to specify Kernel class, related PR:
symfony/symfony#22668
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    78f665f View commit details
    Browse the repository at this point in the history

  4. Bump PHP CS Fixer version to ^2.16.3 

    Configuration and all renamed rules fixed.
Config file renamed to .php_cs.dist as recommended in migration guide.
Migration guide from 1.x to 2.x:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/UPGRADE.md#config-file
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    d40b419 View commit details
    Browse the repository at this point in the history

  5. Remove PHP_CodeSniffer package 

    Second linter doesn't make sense. I think Symfony user would prefer
PHP CS Fixer over PHP_CodeSniffer because first one maintained by Symfony
members.
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    68b3477 View commit details
    Browse the repository at this point in the history

  6. Remove satooshi/php-coveralls package from Composer 

    This package is abandoned and Coveralls recommends to install it directly
in Travis-CI task script.
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    6e66bd6 View commit details
    Browse the repository at this point in the history

  7. Update Travic-CI config 

    I've changed test versions to PHP 7.1.3 and 7.2. PHPUnit generates
coverage report in report/logs/clover.xml file. Then PHP CS Fixer runs
with --dry-run option to not override anything just to show coding style
errors.
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    4b5864a View commit details
    Browse the repository at this point in the history

  8. Add basic Coveralls config 

    This is basic recommended config for a PHP based project.
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    e1d0e88 View commit details
    Browse the repository at this point in the history

  9. Add symfony/yaml package 

    This package was part of satooshi/php-coveralls, now it should be
defined as dev dependency.
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    455392a View commit details
    Browse the repository at this point in the history

  10. Do not commit composer.lock 

    I think committed composer.lock can cause CI errors while tests on fresh
installs are better.
    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    cee3f05 View commit details
    Browse the repository at this point in the history

  11. Remove confusing Ruby comment

    @ybelenko
    ybelenko committed May 8, 2020
    Configuration menu
    Copy the full SHA
    62c7c61 View commit details
    Browse the repository at this point in the history