-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][general] Add metadata file tracking to aid in "Golden Tests" regeneration #6325
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
* master: Update username (arun-nalla) (#6319) [typescript-axios] Implement useSingleRequestParameter option (#6288) [typescript] Remove "v4-compat" value of enumSuffix (#6308) Mark swift4 generator as deprecated (#6311) Remove @nickmeinhold from Dart technical committee (#6309) Migrate Erlang samples to use OAS 3 spec (#6297) update dart samples Improve parameter documentation (#6092) Minor improvements to `plantuml` doc generator (#6298) undo changes to petstore.yaml oas3.0 (#6299) Allow passing progress callbacks through client methods. (#6261) Create method to json (#6111)
That's the issue reported by Drone.io CI. I couldn't repeat the issue locally and I don't see any changes to ./bin/swift5-petstore-readonlyProperties.json in this PR .... |
@wing328 yeah I didn't touch that file or anything to do with deserialize logic. Drone sometimes gets into some state that I can't clear (probably bad cache). |
Minor suggestion: what about adding 1 or 2 lines (starting with # to indicate it's a comment) explaining what |
@wing328 I don't think adding a comment is necessary here. The filename and contents are pretty self explanatory. We can document online if people require more details. |
The actual error in Drone.io CI is
I can now repeat the issue in the master. Does the error message give you any clue on why `./bin/cpp-qt5-petstore.sh failed to run? |
* master: [samples] Regenerate python-experimental [core][general] Add metadata file tracking to aid in "Golden Tests" regeneration (OpenAPITools#6325) [python-experimental] Add support for pep 3134, attach cause of exception (OpenAPITools#6388) [Java-jersey2] Add new ApiClient constructor with auth objects (OpenAPITools#6393)
Discussed this with @Fjolnir-Dvorak as a way to simplify his #4030.
This adds a
FILES
file under the metadata directory in the generated directory.The idea is that we could use this to allow for automatic "clean" of generated sources to avoid issues where file renames or stale files require manual cleanup.
cc @OpenAPITools/generator-core-team
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.