Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of useOneOfInterfaces for Spring and all JaxRS based generators #6589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rfecher
Copy link

@rfecher rfecher commented Jun 8, 2020

This is actually referenced here and it addresses issue #5381 nicely.

I'm willing to do the legwork to get the PR in, however I'm not actually the author, and I'd think to maintain the license agreement we'd need consent from @mmalygin

PR checklist

this step is unclear to me, I run a bunch of the scripts and it seems many seemingly unrelated files changed like all the FakeApi.java files changed put("http", EncodingUtils.encodeCollection(value, "ssv")); to put("http", EncodingUtils.encodeCollection(value, "space")); which seems completely outside of the scope of this bugfix

  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
    further guidance would be appreciated here
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

…rators

Add support of useOneOfInterfaces for Spring and all JaxRS based generators
@wing328
Copy link
Member

wing328 commented Jun 9, 2020

@dang-gyg
Copy link

hey guys, any updates on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants