Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript] Fix array model of alias to array #6888

Merged
merged 3 commits into from
Jul 16, 2020
Merged

[Typescript] Fix array model of alias to array #6888

merged 3 commits into from
Jul 16, 2020

Conversation

bodograumann
Copy link
Contributor

This applies the bug fix #4981 to the refactored typescript generator.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Not really related to this bug fix, but probably necessary for ci
checks.
@bodograumann
Copy link
Contributor Author

I also ran into the any type problem from #6332.
My workaround was to properly define all the types, but this should probably be fixed in the generator as well.
Maybe someone has some time to apply #6335 to the refactored generator.

@macjohnny
Copy link
Member

@bodograumann is this ready to be merged?

@bodograumann
Copy link
Contributor Author

Yes, this is ready imho. @macjohnny

@macjohnny macjohnny merged commit 7cb8766 into OpenAPITools:master Jul 16, 2020
@macjohnny macjohnny added this to the 5.0.0 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants