Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Released version in maven samples #693

Merged
merged 2 commits into from
Jul 31, 2018

Conversation

jmini
Copy link
Member

@jmini jmini commented Jul 30, 2018

PR checklist

  • Read the contribution guidelines.
  • [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

All our docs (Readme, ...) and examples (gradle, ...) mention the last released version. It should be the same for the maven example.

In addition when we do a release, we use bin/utils/release_version_update_docs.sh (see #649), those files should also be updated.

@jmini jmini merged commit 8246549 into OpenAPITools:master Jul 31, 2018
@jmini jmini added this to the 3.2.0 milestone Jul 31, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Fixing maven examples:  set version to last released version and other improvements
* Include example poms in the "release_version_update_docs.sh" script
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023
* chore(deps): upgrade @nestjs to 9.3.9

* chore(deps): expect error TS2339

* chore(deps): update dependency @types/lodash to v4.14.191

* chore(deps): update dependency dotenv to v16.0.3

* chore(deps): update dependency ts-jest to v27.1.5

* fix(deps): update dependency compare-versions to v4.1.4

* fix(deps): update dependency inquirer to v8.2.5

* fix(deps): update nest monorepo

* chore(deps): update commitlint monorepo

* chore(deps): update dependency @types/jest to v27.5.2

* chore(deps): update dependency @types/node to v16.18.18

* chore(deps): update dependency eslint-config-prettier to v8.8.0

* fix(deps): update nest monorepo to v9.3.11

* chore(deps): update dependency prettier to v2.8.6

* chore(deps): update dependency ts-node to v10.9.1

* chore(deps): update dependency type-fest to v2.19.0

* chore(deps): update dependency typescript to v4.9.5

* chore(deps): update typescript-eslint monorepo to v5.56.0

* fix(deps): update dependency @nestjs/axios to v0.1.1

* fix(deps): update dependency fs-extra to v10.1.0

* fix(deps): update dependency rxjs to v7.8.0

* chore: work around TS2339

* chore: revert 6a0140c8e7c061d0abf93cb52f9e891dbcc6860f

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants