Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impls for Error trait for Rust reqwest #7462

Merged
merged 2 commits into from
Oct 25, 2020

Conversation

aidanhs
Copy link
Contributor

@aidanhs aidanhs commented Sep 20, 2020

Adds Error trait impls for the common error types so that they can be chained via normal rust error handling libraries.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)

@aidanhs aidanhs changed the title Aphs rust error impl Add impls for Error trait for Rust reqwest Sep 20, 2020
@wing328 wing328 added this to the 5.0.0 milestone Oct 25, 2020
@wing328
Copy link
Member

wing328 commented Oct 25, 2020

@aidanhs thanks for the PR. Let's give it a try.

@wing328 wing328 merged commit c0e36b3 into OpenAPITools:master Oct 25, 2020
@aidanhs aidanhs deleted the aphs-rust-error-impl branch October 25, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants