-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds python-experimental which uses dynamic base classes #8325
Merged
spacether
merged 1 commit into
OpenAPITools:master
from
spacether:adds_python_experimental_dynamic_base_classes
Jan 5, 2022
Merged
Adds python-experimental which uses dynamic base classes #8325
spacether
merged 1 commit into
OpenAPITools:master
from
spacether:adds_python_experimental_dynamic_base_classes
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
changed the title
Adds python experimental dynamic base classes
Adds python-experimental which uses dynamic base classes
Jan 15, 2021
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
from
January 18, 2021 18:13
16357f1
to
3a55984
Compare
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
2 times, most recently
from
January 21, 2021 18:44
8848551
to
0f34f4f
Compare
5 tasks
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
2 times, most recently
from
March 8, 2021 15:51
87b7f0b
to
30c02b3
Compare
This was referenced Mar 8, 2021
Merged
5 tasks
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
4 times, most recently
from
May 27, 2021 02:16
156e66b
to
573a3f4
Compare
This was referenced Jun 3, 2021
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
3 times, most recently
from
July 13, 2021 15:37
36c6151
to
764e68e
Compare
5 tasks
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
3 times, most recently
from
August 9, 2021 01:55
70e66d3
to
eba9916
Compare
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
2 times, most recently
from
September 6, 2021 03:09
6529f36
to
3644311
Compare
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
5 times, most recently
from
December 20, 2021 20:27
e374308
to
a47830e
Compare
This was referenced Dec 20, 2021
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
4 times, most recently
from
December 28, 2021 22:34
9dd1a14
to
5196228
Compare
6 tasks
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
2 times, most recently
from
January 4, 2022 02:27
f0b2bcc
to
5615747
Compare
spacether
added
Bleeding Edge
Experimental features (e.g. non-standard spec, "futures", or IETF draft)
Client: Python
and removed
Bleeding Edge
Experimental features (e.g. non-standard spec, "futures", or IETF draft)
labels
Jan 5, 2022
spacether
force-pushed
the
adds_python_experimental_dynamic_base_classes
branch
from
January 5, 2022 19:48
a5ece01
to
3bfd851
Compare
This was referenced Jan 5, 2022
4 tasks
If people want to continue using this generator in the future please use it from https://github.com/openapi-json-schema-tools/openapi-json-schema-generator as it is being moved there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds python-experimental which uses dynamic base classes
In this PR:
This is amore robust composition implementation than the standard python generator implementation because:
Separate endpoint parameters are made for for query, path, cookie, and header params because each of those types can contain parameters with colliding names. So having them separate allows us to preserve the original key naming in our inputs to the endpoint. One can see this working in the parameter_collisions endpoint that I added.
Examples
Caviats:
Feature Additions:
Long Term Benefits of Using Dynamic Base Classes + This New structure
str, number
vsnumber
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x