Skip to content

Commit

Permalink
feat: ratelimiter support auto tune
Browse files Browse the repository at this point in the history
  • Loading branch information
wanghenshui committed Apr 9, 2023
1 parent d03f8a4 commit 569a355
Show file tree
Hide file tree
Showing 4 changed files with 49 additions and 2 deletions.
8 changes: 8 additions & 0 deletions include/pika_conf.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ class PikaConf : public pstd::BaseConf {
int consensus_level() { return consensus_level_.load(); }
int replication_num() { return replication_num_.load(); }
int64_t rate_limiter_bandwidth() { RWLock l(&rwlock_, false); return rate_limiter_bandwidth_; }
int64_t rate_limiter_refill_period_us() { RWLock l(&rwlock_, false); return rate_limiter_refill_period_us_; }
int64_t rate_limiter_fairness() { RWLock l(&rwlock_, false); return rate_limiter_fairness_; }
bool rate_limiter_auto_tuned() { RWLock l(&rwlock_, false); return rate_limiter_auto_tuned_; }


// Immutable config items, we don't use lock.
bool daemonize() { return daemonize_; }
Expand Down Expand Up @@ -355,6 +359,10 @@ class PikaConf : public pstd::BaseConf {
bool optimize_filters_for_hits_;
bool level_compaction_dynamic_level_bytes_;
int64_t rate_limiter_bandwidth_ = 200 * 1024 * 1024; // 200M
int64_t rate_limiter_refill_period_us_ = 100 * 1000;
int64_t rate_limiter_fairness_ = 10;
bool rate_limiter_auto_tuned_ = true;

std::atomic<int> sync_window_size_;
std::atomic<int> max_conn_rbuf_size_;
std::atomic<int> consensus_level_;
Expand Down
18 changes: 18 additions & 0 deletions src/pika_admin.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1745,6 +1745,24 @@ void ConfigCmd::ConfigGet(std::string& ret) {
EncodeInt64(&config_body, g_pika_conf->rate_limiter_bandwidth());
}

if (pstd::stringmatch(pattern.data(), "rate-limiter-refill-period-us", 1)) {
elements += 2;
EncodeString(&config_body, "rate-limiter-refill-period-us");
EncodeInt64(&config_body, g_pika_conf->rate_limiter_refill_period_us());
}

if (pstd::stringmatch(pattern.data(), "rate-limiter-fairness", 1)) {
elements += 2;
EncodeString(&config_body, "rate-limiter-fairness");
EncodeInt64(&config_body, g_pika_conf->rate_limiter_fairness());
}

if (pstd::stringmatch(pattern.data(), "rate-limiter-auto-tuned", 1)) {
elements += 2;
EncodeString(&config_body, "rate-limiter-auto-tuned");
EncodeString(&config_body, g_pika_conf->rate_limiter_auto_tuned() ? "yes" : "no");
}

std::stringstream resp;
resp << "*" << std::to_string(elements) << "\r\n" << config_body;
ret = resp.str();
Expand Down
16 changes: 16 additions & 0 deletions src/pika_conf.cc
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,22 @@ int PikaConf::Load()
rate_limiter_bandwidth_ = 200 * 1024 * 1024; // 200MB
}

// rate-limiter-refill-period-us
GetConfInt64("rate-limiter-refill-period-us", &rate_limiter_refill_period_us_);
if (rate_limiter_refill_period_us_ <= 0 ) {
rate_limiter_refill_period_us_ = 100 * 1000;
}

// rate-limiter-fairness
GetConfInt64("rate-limiter-fairness", &rate_limiter_fairness_);
if (rate_limiter_fairness_ <= 0 ) {
rate_limiter_fairness_ = 10;
}

std::string at;
GetConfStr("rate-limiter-auto-tuned", &at);
rate_limiter_auto_tuned_ = (at == "yes" || at.empty()) ? true : false;

// max_write_buffer_num
max_write_buffer_num_ = 2;
GetConfInt("max-write-buffer-num", &max_write_buffer_num_);
Expand Down
9 changes: 7 additions & 2 deletions src/pika_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1681,8 +1681,13 @@ void PikaServer::InitStorageOptions() {
}

storage_options_.options.rate_limiter =
std::shared_ptr<rocksdb::RateLimiter>(rocksdb::NewGenericRateLimiter(g_pika_conf->rate_limiter_bandwidth()));

std::shared_ptr<rocksdb::RateLimiter>(
rocksdb::NewGenericRateLimiter(
g_pika_conf->rate_limiter_bandwidth(),
g_pika_conf->rate_limiter_refill_period_us(),
g_pika_conf->rate_limiter_fairness(),
g_pika_conf->rate_limiter_auto_tuned()
));
// For Storage small compaction
storage_options_.statistics_max_size = g_pika_conf->max_cache_statistic_keys();
storage_options_.small_compaction_threshold =
Expand Down

0 comments on commit 569a355

Please sign in to comment.