Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pika的代码中对key是否上了重复的锁 #2322

Closed
Mixficsol opened this issue Jan 15, 2024 · 2 comments · Fixed by #2372
Closed

Pika的代码中对key是否上了重复的锁 #2322

Mixficsol opened this issue Jan 15, 2024 · 2 comments · Fixed by #2372
Labels
☢️ Bug Something isn't working

Comments

@Mixficsol
Copy link
Collaborator

Mixficsol commented Jan 15, 2024

Description

如图中在cmd层面已经对key进行了上锁,在storage层也对key上锁了,对于锁key防止并发写的这两把锁是不是重复了
截屏2024-01-15 19 45 10
截屏2024-01-15 19 45 30

@Mixficsol Mixficsol added the ☢️ Bug Something isn't working label Jan 15, 2024
@AlexStocks
Copy link
Collaborator

@AlexStocks
Copy link
Collaborator

问题 1,lock 是为了保证 cmd 的 lock 与 binlog 写顺序,不是问题。
问题 2,可以改进优化。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☢️ Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants