Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete reduntant lock in storage #2372

Merged
merged 4 commits into from
Mar 7, 2024
Merged

fix: delete reduntant lock in storage #2372

merged 4 commits into from
Mar 7, 2024

Conversation

Mixficsol
Copy link
Collaborator

@Mixficsol Mixficsol commented Feb 1, 2024 •
edited
Loading

这个 PR 中主要做了两件事：

  1. 由于 Pika 的 CMD 层上了 Key 锁，所以把 Redis 层的 Key 锁进行了删除
  2. 如图所示，在 DB 层有两个重复的 shared_mutex 保护 DB 的变量，对于它们两个进行了整合操作
截屏2024-02-01 11 42 04

fix: #2322

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Feb 1, 2024
@AlexStocks AlexStocks changed the title fix: fix lock fix: delete reduntant lock in storage Feb 2, 2024
@AlexStocks
Copy link
Collaborator

https://wanghenshui.github.io/2020/07/14/reduce-lock.html

@Mixficsol Mixficsol added 3.5.3 and removed 3.5.4 labels Mar 1, 2024
@wanghenshui
Copy link
Collaborator

LGTM，加点测试用例，构造一下竞争场景

@AlexStocks AlexStocks merged commit b743303 into OpenAtomFoundation:unstable Mar 7, 2024
13 checks passed
@Mixficsol Mixficsol deleted the fix_lock branch March 14, 2024 12:16
@Mixficsol Mixficsol restored the fix_lock branch March 15, 2024 07:15
@Mixficsol Mixficsol deleted the fix_lock branch March 15, 2024 07:15
Mixficsol added a commit that referenced this pull request Mar 15, 2024
@Mixficsol
Revert "fix lock (#2372)"
5cfc23f 
This reverts commit b743303.
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@Mixficsol
fix lock (OpenAtomFoundation#2372)
e4bc855 
Co-authored-by: wuxianrong <[email protected]>
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
@Mixficsol
fix lock (OpenAtomFoundation#2372)
3a0a09c 
Co-authored-by: wuxianrong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@dingxiaoshuai123 dingxiaoshuai123 dingxiaoshuai123 approved these changes

@wangshao1 wangshao1 Awaiting requested review from wangshao1

@baixin01 baixin01 Awaiting requested review from baixin01

Assignees
No one assigned
Labels
3.5.3 ☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pika的代码中对key是否上了重复的锁
4 participants
@Mixficsol @AlexStocks @wanghenshui @dingxiaoshuai123