Fix EXISTS and DEL bug for sharding and consensus situation #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In sharding and consensus situation, SXISTS command will call Do instead of Split, this lead response message append twice in Do and Merge. For DEL command, this is a write command, and for consensus case, pika will call Execute twice for DoBinlog and DoCommand respectively, and cause Merge called double.
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…ts-del-bug Fix EXISTS and DEL bug for sharding and consensus situation
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…ts-del-bug Fix EXISTS and DEL bug for sharding and consensus situation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sharding and consensus situation, SXISTS command will call Do instead of Split,
this lead response message append twice in Do and Merge.
For DEL command, this is a write command, and for consensus case, pika will call
Execute twice for DoBinlog and DoCommand respectively, and cause Merge called double.