Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add pika_exporter to pika #1388

Merged
merged 11 commits into from
May 9, 2023
Merged

build: add pika_exporter to pika #1388

merged 11 commits into from
May 9, 2023

Conversation

chenbt-hz
Copy link
Collaborator

@chenbt-hz chenbt-hz commented Apr 21, 2023

1.add pika_exporter to pika
2.update some metric
fix #1336
fix #1230

Notes:
The current version can be compiled and used, but further updates and verification are still needed in the future.

@wanghenshui
Copy link
Collaborator

wanghenshui commented Apr 22, 2023

几个问题

  • 需要支持流水线编译
  • 放在codis那层目录合适还是放在pika tools目录合适?

@chenbt-hz
Copy link
Collaborator Author

  • 放在codis那层目录合适还是放在pika tools目录合适?

个人感觉放pika tools目录就行。

  1. pika相关工具都放一起,比较方便查找和管理。
  2. pika-exporter跟codis目前没什么依赖关系。

@chenbt-hz chenbt-hz changed the title add pika_exporter to pika (#1336) add pika_exporter to pika (#1336,#1230) Apr 24, 2023
Copy link
Collaborator

@wanghenshui wanghenshui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了3.3.5其他的都删了,不兼容了

@wanghenshui
Copy link
Collaborator

@pourer

@wanghenshui wanghenshui changed the title add pika_exporter to pika (#1336,#1230) add pika_exporter to pika Apr 24, 2023
@wanghenshui wanghenshui changed the title add pika_exporter to pika build: add pika_exporter to pika Apr 24, 2023
@wanghenshui wanghenshui self-requested a review April 24, 2023 09:20
@wanghenshui wanghenshui self-requested a review May 4, 2023 12:01
pika-tools/pika_exporter/.gitignore Outdated Show resolved Hide resolved
pika-tools/pika_exporter/vendor/modules.txt Outdated Show resolved Hide resolved
@AlexStocks
Copy link
Collaborator

1 删除 go vendor
2 说明新添加的内容

@AlexStocks
Copy link
Collaborator

1 删除 go vendor 2 说明新添加的内容

@chenbt-hz 你改完的话,请给个回复,我开始review下

@chenbt-hz
Copy link
Collaborator Author

1 删除 go vendor 2 说明新添加的内容

@chenbt-hz 你改完的话,请给个回复,我开始review下

1.vendor目录已经去除,编译通过。
2.README.md文件更新了metric列表,以树根整理的作为基础。新增完成的metric前面加了(new),部分指标我新增时未找到或在源码里没查到,因此我暂时在这类metric前面加了(no exists)

@wanghenshui
Copy link
Collaborator

ping @AlexStocks

@AlexStocks AlexStocks merged commit 0ec9951 into OpenAtomFoundation:unstable May 9, 2023
@yaoyinnan yaoyinnan mentioned this pull request Jul 27, 2023
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
* add pika-exporter

* add pika-exporter: fix README.md

* add pika-exporter: fix README.md

* add pika-exporter: remove annotation ,recover version.go

* 更新远程仓库路径

* update Makefile

* Create pika_exporter.yml

* Delete the old version of the test file and it will no longer be compatible in the future

* Remove vendor;update README.md
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
* add pika-exporter

* add pika-exporter: fix README.md

* add pika-exporter: fix README.md

* add pika-exporter: remove annotation ,recover version.go

* 更新远程仓库路径

* update Makefile

* Create pika_exporter.yml

* Delete the old version of the test file and it will no longer be compatible in the future

* Remove vendor;update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate pika_exporter into pika repo pika port、pika export 项目迁移到pika仓库
3 participants