Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete sharding command #1469

Merged
merged 3 commits into from
May 9, 2023
Merged

fix: delete sharding command #1469

merged 3 commits into from
May 9, 2023

Conversation

chejinge
Copy link
Collaborator

@chejinge chejinge commented May 9, 2023

pkcluster addtable && pkcluster deltable&&pkcluster addslots&&pkcluster delslots&&pkcluster slaveof

@chejinge chejinge changed the title delete_sharding_commod delete_sharding_command May 9, 2023
@chejinge chejinge changed the title delete_sharding_command delete_sharding_command--pkclusteraddtable&&pkclusterdeltable May 9, 2023
@chejinge
Copy link
Collaborator Author

chejinge commented May 9, 2023

删除pika sharding模式下的命令 pkclusteraddtable和pkclusterdeltable

@AlexStocks AlexStocks changed the title delete_sharding_command--pkclusteraddtable&&pkclusterdeltable delete sharding command:pkclusteraddtable & &pkclusterdeltable May 9, 2023
@AlexStocks AlexStocks changed the title delete sharding command:pkclusteraddtable & &pkclusterdeltable delete sharding command:pkcluster addtable & &pkcluster deltable May 9, 2023
@AlexStocks
Copy link
Collaborator

pika_cluster.h 里面 PkClusterAddTableCmd&PkClusterDelTableCmd 怎么依然保留着?

@chejinge chejinge closed this May 9, 2023
@chejinge
Copy link
Collaborator Author

chejinge commented May 9, 2023

pika_cluster.h 里面 PkClusterAddTableCmd&PkClusterDelTableCmd 怎么依然保留着?

ok,已经删除

@chejinge chejinge reopened this May 9, 2023
@AlexStocks AlexStocks changed the title delete sharding command:pkcluster addtable & &pkcluster deltable delete sharding command:pkcluster addtable && pkcluster deltable May 9, 2023
@chejinge chejinge changed the title delete sharding command:pkcluster addtable && pkcluster deltable delete sharding command:pkcluster addtable && pkcluster deltable&&pkcluster addslots&&pkcluster delslots&&pkcluster slaveof May 9, 2023
@AlexStocks
Copy link
Collaborator

AlexStocks commented May 9, 2023

这个 pr 先不急着合并,等 @wanghenshui 对 删除 sharding 模式这个事,表个态。

@AlexStocks AlexStocks removed the request for review from loveyacper May 9, 2023 12:18
@AlexStocks AlexStocks merged commit 30c53f0 into OpenAtomFoundation:unstable May 9, 2023
@yaoyinnan yaoyinnan changed the title delete sharding command:pkcluster addtable && pkcluster deltable&&pkcluster addslots&&pkcluster delslots&&pkcluster slaveof fix: delete sharding command Jul 25, 2023
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
…luster addslots&&pkcluster delslots&&pkcluster slaveof (OpenAtomFoundation#1469)

* delete_sharding_commod

* delete_command

* delete_sharding_command
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
…luster addslots&&pkcluster delslots&&pkcluster slaveof (OpenAtomFoundation#1469)

* delete_sharding_commod

* delete_command

* delete_sharding_command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants