Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use RAII to release resources in async task #1502

Merged
merged 3 commits into from
May 16, 2023
Merged

fix: use RAII to release resources in async task #1502

merged 3 commits into from
May 16, 2023

Conversation

A2ureStone
Copy link
Contributor

No description provided.

@wanghenshui wanghenshui changed the title use raii to release resources in async task fix: use raii to release resources in async task May 15, 2023
@AlexStocks AlexStocks changed the title fix: use raii to release resources in async task fix: use RAII to release resources in async task May 15, 2023
@AlexStocks
Copy link
Collaborator

image

如果 arg 是 new 出来的，这么改动，能保证 arg 会被释放掉么？

@A2ureStone
Copy link
Contributor Author

可以的， unique_ptr接受一个指针， 在析构的时候调用对应参数类型的delete函数

loveyacper
loveyacper reviewed May 16, 2023
View reviewed changes
src/pika_client_conn.cc Outdated Show resolved Hide resolved
@loveyacper
Copy link
Collaborator

loveyacper commented May 16, 2023 •
edited
Loading

传递void*指针，基本是编码设计上的缺陷，本次修改治标。若治本，未来要解决掉 void*。

@AlexStocks AlexStocks merged commit 979d16d into OpenAtomFoundation:unstable May 16, 2023
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@A2ureStone
fix: use RAII to release resources in async task (OpenAtomFoundation#…
3abee90 
…1502)

* use raii to release resources in async task

* use static_cast instead of reinterpret_cast

---------

Co-authored-by: J1senn <[email protected]>
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
@A2ureStone
fix: use RAII to release resources in async task (OpenAtomFoundation#…
d2e9cfd 
…1502)

* use raii to release resources in async task

* use static_cast instead of reinterpret_cast

---------

Co-authored-by: J1senn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luky116 luky116 luky116 approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@loveyacper loveyacper loveyacper approved these changes

@wanghenshui wanghenshui Awaiting requested review from wanghenshui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@A2ureStone @AlexStocks @loveyacper @luky116