feat:add lastsave cmd #2167
Merged
feat:add lastsave cmd #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanghenshui
reviewed
Nov 25, 2023
src/pika_admin.cc
Outdated
| @@ -308,6 +308,10 @@ void BgsaveCmd::Do(std::shared_ptr<Slot> slot) { | |||
| g_pika_server->DoSameThingSpecificDB(TaskType::kBgSave, bgsave_dbs_); | |||
| LogCommand(); | |||
| res_.AppendContent("+Background saving started"); | |||
| memset(&bgSaveTimeTv,0,sizeof(struct timeval)); | |||
wanghenshui
reviewed
Nov 26, 2023
wanghenshui
reviewed
Nov 26, 2023
|
补充单元测试
|
|
lastsave_ 没有必要是static的，可以改掉 |
AlexStocks
reviewed
Dec 1, 2023
hero-heng
force-pushed
the
lastsaveCmd
branch
from
d7db96d
to
6b93236
Compare
hero-heng
force-pushed
the
lastsaveCmd
branch
from
6b93236
to
eab7a6b
Compare
|
多余文件删掉 |
|
单测没过 |
wanghenshui
approved these changes
Dec 14, 2023
AlexStocks
approved these changes
Dec 14, 2023
AlexStocks
merged commit ba0d5ce
into
OpenAtomFoundation:unstable
12 of 13 checks passed
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* feat:unstable branch * feat:handle merge * feat:add lastsave cmd * feat:update lastsave cmd * feat:update lastsave cmd * feat:fixed lastsave cmd * feat:fixed server_test.go * feat:fixed server_test.go * feat:fixed server_test.go * feat:fixed server_test.go * feat:update modifies * feat:delete redundant files * feat:fixed server_test * feat:update code * feat:update server_test * feat:update ut
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* feat:unstable branch * feat:handle merge * feat:add lastsave cmd * feat:update lastsave cmd * feat:update lastsave cmd * feat:fixed lastsave cmd * feat:fixed server_test.go * feat:fixed server_test.go * feat:fixed server_test.go * feat:fixed server_test.go * feat:update modifies * feat:delete redundant files * feat:fixed server_test * feat:update code * feat:update server_test * feat:update ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1161