Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some commands of Set do not have status return values from RocksDB #2187

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

callme-taota
Copy link
Contributor

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Dec 7, 2023
@AlexStocks
Copy link
Collaborator

添加下 Go 单测

src/pika_set.cc Outdated Show resolved Hide resolved
src/pika_set.cc Outdated Show resolved Hide resolved
src/pika_set.cc Outdated Show resolved Hide resolved
src/pika_set.cc Outdated Show resolved Hide resolved
src/pika_set.cc Outdated Show resolved Hide resolved
@Mixficsol
Copy link
Collaborator

LGTM

@AlexStocks
Copy link
Collaborator

LGTM

等 go 测试添加完再 merge

@Mixficsol Mixficsol merged commit 91a293b into OpenAtomFoundation:unstable Dec 14, 2023
13 checks passed
Copy link
Collaborator

@AlexStocks AlexStocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@callme-taota callme-taota deleted the issues#2185 branch December 14, 2023 05:34
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
…ocksDB (OpenAtomFoundation#2187)

* fix: have no status return values from RocksDB

* fix: have no status return values from RocksDB

* feat: add go test
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
…ocksDB (OpenAtomFoundation#2187)

* fix: have no status return values from RocksDB

* fix: have no status return values from RocksDB

* feat: add go test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.3 ☢️ Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants