-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Go test for blpop brpop #2193
Merged
AlexStocks
merged 1 commit into
OpenAtomFoundation:unstable
from
Summer-0827:go_test_of_blpop_brpop
Dec 11, 2023
Merged
feat:Go test for blpop brpop #2193
AlexStocks
merged 1 commit into
OpenAtomFoundation:unstable
from
Summer-0827:go_test_of_blpop_brpop
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
✏️ Feature
New feature or request
and removed
Invalid PR Title
labels
Dec 8, 2023
AlexStocks
reviewed
Dec 9, 2023
tests/integration/list_test.go
Outdated
@@ -10,9 +11,33 @@ import ( | |||
"github.com/redis/go-redis/v9" | |||
) | |||
|
|||
func blpopThread(ctx *context.Context, client *redis.Client, lists []string, timeout time.Duration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
把 Thread 统一删掉,改为 issueBlpop 之类
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
Summer-0827
force-pushed
the
go_test_of_blpop_brpop
branch
from
December 9, 2023 14:45
4374980
to
8192cee
Compare
Summer-0827
force-pushed
the
go_test_of_blpop_brpop
branch
from
December 10, 2023 13:55
b760a1a
to
369bff4
Compare
AlexStocks
approved these changes
Dec 11, 2023
dingxiaoshuai123
approved these changes
Dec 11, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
Co-authored-by: yaxin0710 <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Co-authored-by: yaxin0710 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:#2165