feat: Exporter for Proxy #2199
Merged
feat: Exporter for Proxy #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenbt-hz
reviewed
Dec 12, 2023
chenbt-hz
reviewed
Dec 12, 2023
chenbt-hz
reviewed
Dec 12, 2023
dingxiaoshuai123
force-pushed
the
exporter_for_proxy
branch
from
086ab75
to
561d98b
Compare
dingxiaoshuai123
changed the title
dingxiaoshuai123
force-pushed
the
exporter_for_proxy
branch
from
561d98b
to
9e75379
Compare
dingxiaoshuai123
force-pushed
the
exporter_for_proxy
branch
from
b58fdbd
to
e13eff8
Compare
chenbt-hz
reviewed
Dec 19, 2023
codis/pkg/proxy/stats.go
Outdated
| @@ -72,6 +78,16 @@ func init() { | |||
| cmdstats.qps.Set(int64(normalized + 0.5)) | |||
| } | |||
| }() | |||
|
|
|||
| // Clear the accumulated maximum delay to 0 every 15 seconds. | |||
There was a problem hiding this comment.
这边辛苦小帅调整下，改成动态可配置重置时间，会更好些。避免信息缺失
chenbt-hz
reviewed
Dec 19, 2023
| "datacenter": "" | ||
| } | ||
| ], | ||
| "stats": { |
dingxiaoshuai123
force-pushed
the
exporter_for_proxy
branch
from
7cf2b02
to
97039c2
Compare
chenbt-hz
approved these changes
Dec 19, 2023
AlexStocks
reviewed
Dec 21, 2023
codis/pkg/proxy/config.go
Outdated
| @@ -323,5 +328,9 @@ func (c *Config) Validate() error { | |||
| return errors.New("invalid metrics_report_statsd_period") | |||
| } | |||
|
|
|||
| if c.MaxDelayRefreshTimeInterval <= 0 { | |||
| return errors.New("invalid max_delay_refresh_time_interval") | |||
There was a problem hiding this comment.
max_delay_refresh_time_interval must be greater than 0
AlexStocks
reviewed
Dec 21, 2023
codis/pkg/proxy/proxy.go
Outdated
| return redis.NewErrorf("err：%s.", err) | ||
| } | ||
| if d := p.config.MaxDelayRefreshTimeInterval.Duration(); d <= 0 { | ||
| return redis.NewErrorf("invalid max_delay_refresh_time_interval") |
There was a problem hiding this comment.
max_delay_refresh_time_interval must be greater than 0
AlexStocks
reviewed
Dec 21, 2023
| @@ -174,7 +206,7 @@ func (d *codisDiscovery) CheckUpdate(updatechan chan int, codisaddr string) { | |||
| } | |||
|
|
|||
| func (d *codisDiscovery) comparedis(new_instance *codisDiscovery) bool { | |||
| var addrs []string | |||
| var addrs, addrsProxy []string | |||
There was a problem hiding this comment.
var (
addrs []string
addrsProxy []string
diff bool
)
AlexStocks
reviewed
Dec 21, 2023
| @@ -36,3 +36,38 @@ func (f *future) Wait() map[futureKey]error { | |||
| defer f.Unlock() | |||
| return f.m | |||
| } | |||
|
|
|||
| type futureKeyForProxy struct { | |||
| addr, ID, productName string | |||
AlexStocks
reviewed
Dec 21, 2023
|
|
||
| func (f *futureForProxy) Done(key futureKeyForProxy, val error) { | ||
| f.Lock() | ||
| defer f.Unlock() |
There was a problem hiding this comment.
defer func() {
f.Unlock()
f.wait.Done()
}()
AlexStocks
reviewed
Dec 21, 2023
| elemType := field.Index(j).Type() | ||
| elemValue := field.Index(j) | ||
| if elemType.Kind() == reflect.Struct { | ||
| var key string |
There was a problem hiding this comment.
key := elemValue.Field(0).String()
for p := 1; p < elemValue.NumField(); p++ {
cmdResult[key] = append(cmdResult[key], elemValue.Field(p).Int())
}
AlexStocks
reviewed
Dec 21, 2023
AlexStocks
reviewed
Dec 21, 2023
dingxiaoshuai123
force-pushed
the
exporter_for_proxy
branch
from
97039c2
to
e6f0775
Compare
dingxiaoshuai123
force-pushed
the
exporter_for_proxy
branch
from
e6f0775
to
f7c73b8
Compare
AlexStocks
approved these changes
Dec 21, 2023
AlexStocks
merged commit cacb428
into
OpenAtomFoundation:unstable
12 of 14 checks passed
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* First edition * Exporter collects Proxy information. * Improve metrics * Dynamically adjust refresh time.
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* First edition * Exporter collects Proxy information. * Improve metrics * Dynamically adjust refresh time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue : #2201
issue : #2208
Add metric collection for Proxy instances in the exporter
以下是本地压测set命令时， exporter采集的有关proxy的结果: