fix: after full synchronization fails, full synchronization will be skipped directly(#2433) #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Mar 1, 2024
AlexStocks
reviewed
Mar 5, 2024
| } else { | ||
| SetReplState(ReplState::kError); | ||
| return Status::Error("rsync client init failed!");; |
There was a problem hiding this comment.
line 969 处我看没有记录 s error 的具体内容，所以你定义这个错误没啥用吧
There was a problem hiding this comment.
原来想着定义个bool就行，表示成功或失败。你建议修改成 int 方便以后扩展，所以使用了 Status 。这里的 error 可以记录日志，也可以不记录日志。在调用 ActivateRsync() 函数的地方，有记录日志，需要重新进行全量同步。
wangshao1
approved these changes
Mar 6, 2024
AlexStocks
approved these changes
Mar 6, 2024
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
…kipped directly(OpenAtomFoundation#2433) (OpenAtomFoundation#2439) Co-authored-by: liuchengyu <[email protected]>
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
…kipped directly(OpenAtomFoundation#2433) (OpenAtomFoundation#2439) Co-authored-by: liuchengyu <[email protected]>
luky116
pushed a commit
that referenced
this pull request
Mar 18, 2024
…kipped directly(#2433) (#2439) Co-authored-by: liuchengyu <[email protected]>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…kipped directly(OpenAtomFoundation#2433) (OpenAtomFoundation#2439) Co-authored-by: liuchengyu <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…kipped directly(OpenAtomFoundation#2433) (OpenAtomFoundation#2439) Co-authored-by: liuchengyu <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…kipped directly(OpenAtomFoundation#2433) (OpenAtomFoundation#2439) Co-authored-by: liuchengyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: after full synchronization fails, full synchronization will be skipped directly(#2433)