Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tcl test #2446

Closed
wants to merge 1 commit into from
Closed

feat: add tcl test #2446

wants to merge 1 commit into from

Conversation

Mixficsol
Copy link
Collaborator

@Mixficsol Mixficsol commented Mar 4, 2024

fix: #2046

在这个 PR 中,我们放开了之前注释掉的 basic, scan, expire, multi, quit, list, pubsub, slowlog, protocol, maxmemory, bitops, hyperloglog的 TCL 测试,将 RedisTCL 单测在 Pika 上几乎全部进行了覆盖,至于剩下的一部分单测类型没有解掉注释的原因在于这些类型中部分命令 Pika 暂不支持,例如 Rename, Debug, Move, Save, Sort, Eval, Dump, Command 等命令

In this PR, We let go of the previous comments on basic, scan, expire, multi, quit, list, pubsub, slowlog, protocol, maxmemory, bitops, The TCL test of hyperloglog covers almost all the TCL single test of Redis on Pika. As for the remaining part of the single test types, the reason why the comments are not removed is that some commands of these types are not supported by Pika. For example, Rename, Debug, Move, Save, Sort, Eval, Dump, command, and so on

截屏2024-03-04 16 36 14

@github-actions github-actions bot added ✏️ Feature New feature or request 🧹 Updates This will not be worked on labels Mar 4, 2024
@Mixficsol Mixficsol added wip Work in Progress (PR incomplete - needs more work or rework) 3.5.3 test and removed wip Work in Progress (PR incomplete - needs more work or rework) ✏️ Feature New feature or request labels Mar 4, 2024
@AlexStocks AlexStocks requested review from lqxhub, kernelai and machinly and removed request for kernelai March 8, 2024 12:38
Copy link
Collaborator

@machinly machinly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

由于命令不支持而注释掉的,最好在注释中添加下说明。

@github-actions github-actions bot added the ✏️ Feature New feature or request label Mar 11, 2024
@Mixficsol
Copy link
Collaborator Author

由于命令不支持而注释掉的,最好在注释中添加下说明。

#2046 目前已经记录在这个issue里面了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.3 ✏️ Feature New feature or request test 🧹 Updates This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pika 的 TCL 测试完善计划
2 participants