fix:dbsize caculate error #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Mar 12, 2024
AlexStocks
reviewed
Mar 12, 2024
AlexStocks
reviewed
Mar 12, 2024
AlexStocks
approved these changes
Mar 13, 2024
Mixficsol
approved these changes
Mar 13, 2024
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
* fix: dbsize caculate error
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
* fix: dbsize caculate error
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* fix: dbsize caculate error
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* fix: dbsize caculate error
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* fix: dbsize caculate error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2493
这里为什么不能做dbsize scard优化
首先：scard只是获取slotkey的数量，不是scan出所有的key的大小，scard slotkey的速度风险是可控的
其次：不能做一个数据保存下来，原因是假如在slotsreload,那前一秒和后一秒的keysize相差数据量太大，会不标准