fix: spop binlog , rewritten as srem

include/pika_set.h

@@ -36,10 +36,36 @@ class SAddCmd : public Cmd {
   void DoInitial() override;
 };
 
+class SRemCmd : public Cmd {
+ public:
+  SRemCmd(const std::string& name, int arity, uint32_t flag)
+      : Cmd(name, arity, flag, static_cast<uint32_t>(AclCategory::SET)) {}
+  std::vector<std::string> current_key() const override {
+    std::vector<std::string> res;
+    res.push_back(key_);
+    return res;
+  }
+  void Do() override;
+  void DoUpdateCache() override;
+  void DoThroughDB() override;
+  void Split(const HintKeys& hint_keys) override{};
+  void Merge() override{};
+  Cmd* Clone() override { return new SRemCmd(*this); }
+
+ private:
+  std::string key_;
+  std::vector<std::string> members_;
+  rocksdb::Status s_;
+  int32_t deleted_ = 0;
+  void DoInitial() override;
+};
+
 class SPopCmd : public Cmd {
  public:
   SPopCmd(const std::string& name, int arity, uint32_t flag)
-      : Cmd(name, arity, flag, static_cast<uint32_t>(AclCategory::SET)) {}
+      : Cmd(name, arity, flag, static_cast<uint32_t>(AclCategory::SET)) {
+        srem_cmd_ = std::make_shared<SRemCmd>(kCmdNameSRem, -3, kCmdFlagsWrite |  kCmdFlagsSet);
+      }
   std::vector<std::string> current_key() const override {
     std::vector<std::string> res;
     res.push_back(key_);
@@ -51,10 +77,13 @@ class SPopCmd : public Cmd {
   void Split(const HintKeys& hint_keys) override{};
   void Merge() override{};
   Cmd* Clone() override { return new SPopCmd(*this); }
+  void DoBinlog() override;
 
  private:
   std::string key_;
   std::vector<std::string> members_;
+  // used for write binlog
+  std::shared_ptr<SRemCmd> srem_cmd_;
   int64_t count_ = 1;
   rocksdb::Status s_;
   void DoInitial() override;
@@ -131,30 +160,6 @@ class SScanCmd : public Cmd {
   }
 };
 
-class SRemCmd : public Cmd {
- public:
-  SRemCmd(const std::string& name, int arity, uint32_t flag)
-      : Cmd(name, arity, flag, static_cast<uint32_t>(AclCategory::SET)) {}
-  std::vector<std::string> current_key() const override {
-    std::vector<std::string> res;
-    res.push_back(key_);
-    return res;
-  }
-  void Do() override;
-  void DoUpdateCache() override;
-  void DoThroughDB() override;
-  void Split(const HintKeys& hint_keys) override{};
-  void Merge() override{};
-  Cmd* Clone() override { return new SRemCmd(*this); }
-
- private:
-  std::string key_;
-  std::vector<std::string> members_;
-  rocksdb::Status s_;
-  int32_t deleted_ = 0;
-  void DoInitial() override;
-};
-
 class SUnionCmd : public Cmd {
  public:
   SUnionCmd(const std::string& name, int arity, uint32_t flag)

src/pika_set.cc

@@ -91,6 +91,24 @@ void SPopCmd::DoUpdateCache() {
   }
 }
 
+void SPopCmd::DoBinlog() {
+  if (!s_.ok()) {
+    return;
+  }
+
+  PikaCmdArgsType srem_args;
+  srem_args.emplace_back("srem");
+  srem_args.emplace_back(key_);
+  for (auto m = members_.begin(); m != members_.end(); ++m) {
+    srem_args.emplace_back(*m);
+  }
+
+  srem_cmd_->Initial(srem_args, db_name_);
+  srem_cmd_->SetConn(GetConn());
+  srem_cmd_->SetResp(resp_.lock());
+  srem_cmd_->DoBinlog();
+}
+
 void SCardCmd::DoInitial() {
   if (!CheckArg(argv_.size())) {
     res_.SetRes(CmdRes::kWrongNum, kCmdNameSCard);