fix: unable to start pika exporter #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polaris3003
changed the title
AlexStocks
reviewed
May 8, 2024
tools/pika_exporter/main.go
Outdated
| @@ -19,7 +19,7 @@ import ( | |||
| var ( | |||
| hostFile = flag.String("pika.host-file", getEnv("PIKA_HOST_FILE", ""), "Path to file containing one or more pika nodes, separated by newline. NOTE: mutually exclusive with pika.addr.") | |||
| addr = flag.String("pika.addr", getEnv("PIKA_ADDR", ""), "Address of one or more pika nodes, separated by comma.") | |||
| codisaddr = flag.String("codis.addr", getEnv("CODIS_ADDR", "http://localhost:port/topom"), "Address of one or more codis topom urls, separated by comma.") | |||
| codisaddr = flag.String("codis.addr", getEnv("CODIS_ADDR", ""), "Address of one or more codis topom urls, separated by comma.") | |||
There was a problem hiding this comment.
codisaddr = flag.String("codis.addr", getEnv("CODIS_ADDR", ""), "Address of one or more codis topom urls, separated by comma, such as \"http://localhost:port/topom\".")
AlexStocks
approved these changes
May 8, 2024
dingxiaoshuai123
approved these changes
May 8, 2024
chejinge
pushed a commit
that referenced
this pull request
May 15, 2024
* delete defalut value of codisadr * add description for using codisaddr * Update main.go --------- Co-authored-by: xiaodi05 <[email protected]> Co-authored-by: Xin.Zh <[email protected]>
chenbt-hz
pushed a commit
to chenbt-hz/pika
that referenced
this pull request
Jun 3, 2024
* delete defalut value of codisadr * add description for using codisaddr * Update main.go --------- Co-authored-by: xiaodi05 <[email protected]> Co-authored-by: Xin.Zh <[email protected]>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* delete defalut value of codisadr * add description for using codisaddr * Update main.go --------- Co-authored-by: xiaodi05 <[email protected]> Co-authored-by: Xin.Zh <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* delete defalut value of codisadr * add description for using codisaddr * Update main.go --------- Co-authored-by: xiaodi05 <[email protected]> Co-authored-by: Xin.Zh <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* delete defalut value of codisadr * add description for using codisaddr * Update main.go --------- Co-authored-by: xiaodi05 <[email protected]> Co-authored-by: Xin.Zh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete default value of codisaddr #2634