fix: add back the override Execute() of WatchCmd, InfoCmd, ConfigCmd #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheniujh
changed the title
wangshao1
approved these changes
Jun 4, 2024
chejinge
approved these changes
Jun 4, 2024
AlexStocks
approved these changes
Jun 4, 2024
AlexStocks
merged commit 4b390c0
into
OpenAtomFoundation:unstable
16 of 17 checks passed
chejinge
pushed a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: cjh <[email protected]>
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/OpenAtomFoundation/pika/pull/2533/files, the override Execute() of WatchCmd, InfoCmd, ConfigCmd has been deleted only for simplicity, but those override function has their own unique purpose: avoding calling the Execute() implimented by their base class "Cmd"
PS: No obvious bugs were found, but adding these methods back would be more secure.