Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix econcal endpoint #5567

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix econcal endpoint #5567

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c0645e
fix econcal for python interface
hjoaquim Oct 16, 2023
bcb8999
fix econcal tests
hjoaquim Oct 16, 2023
9761b09
fix non supported json output
hjoaquim Oct 16, 2023
3552cd1
Merge branch 'feature/openbb-sdk-v4' into hotfix/econcal
hjoaquim Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openbb_platform/extensions/economy/integration/test_economy_python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,9 +444,9 @@ def test_economy_gdpforecast(params, obb):
{
"start_date": "2023-01-01",
"end_date": "2023-06-06",
"country": "Portugal",
"country": "portugal",
"importance": 1,
"group": "money",
"group": "gdp",
}
),
],
Expand Down
2 changes: 1 addition & 1 deletion openbb_platform/extensions/economy/openbb_economy/economy_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def gdpforecast(
return OBBject(results=Query(**locals()).execute())


@router.command(model="EconCal")
@router.command(model="EconomicCalendar")
def econcal(
cc: CommandContext,
provider_choices: ProviderChoices,
Expand Down
2 changes: 1 addition & 1 deletion openbb_platform/providers/tradingeconomics/openbb_tradingeconomics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
website="https://tradingeconomics.com/",
description="""Trading Economics""",
required_credentials=["api_key"],
fetcher_dict={"EconCal": TEEarningsCalendarFetcher},
fetcher_dict={"EconomicCalendar": TEEarningsCalendarFetcher},
)
5 changes: 5 additions & 0 deletions openbb_platform/providers/tradingeconomics/openbb_tradingeconomics/utils/url_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,10 @@ def generate_url(in_query):
# Group + Date
elif check_args(query, ["group", "start_date", "end_date"]):
url = f'{base_url}/group/{query["group"]}/{query["start_date"]}/{query["end_date"]}?c='
# All fields
elif check_args(
query, ["country", "group", "importance", "start_date", "end_date"]
):
url = f'{base_url}/country/{country}/group/{group}/{query["start_date"]}/{query["end_date"]}?{urlencode(query)}&c='

return url if url else ""
Loading