Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] - Improve the example test #6203

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[Enhancement] - Improve the example test #6203

merged 1 commit into from
Mar 13, 2024

Conversation

IgorWounds
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • Examples could have parameters passed that don't exist or are typos.

  2. What? (1-3 sentences or a bullet point list):

    • Added a check to ensure that the passed Example parameters are supported by the command.

  3. Impact (1-2 sentences or a bullet point list):

    • Won't change anything substantially. Improves the QA.

  4. Testing Done:

    • Tested that it works.

@IgorWounds IgorWounds changed the title [Feature] - Improve the example test [Enhancement] - Improve the example test Mar 13, 2024
@github-actions github-actions bot added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Mar 13, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Mar 13, 2024
Merged via the queue into develop with commit c0f4f85 Mar 13, 2024
15 of 22 checks passed
@IgorWounds IgorWounds deleted the feature/improve-example-test branch March 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montezdesousa montezdesousa montezdesousa approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorWounds @montezdesousa