[BugFix] Set Chart Style Before Output #6367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
plotly.html
file to set the theme as light/dark mode. For users relying on inline display, the result was a figure with an unset background.Before:
This can be observed from,
res.chart.fig
What? (1-3 sentences or a bullet point list):
chart_style
and then sets thepaper_bgcolor
andfont_color
accordingly.Impact (1-2 sentences or a bullet point list):
Testing Done:
After:
This will update the figure to be the reverse of the
chart_style
preference. It does not render the update,show()
must be used after.