Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/fix-chart - Fix data hand off. #6511

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Hotfix/fix-chart - Fix data hand off. #6511

merged 6 commits into from
Jun 20, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Receiving end encounters unexpected object with the data being passed and fails to create charts.
    • Impacts nearly every chart, it may only be coincidence if fallback methods render correctly.

  2. What?:

    • Passes 'results' instead of OBBject in charting.

  3. Impact:

    • Restores some expected behaviour.
    • May not be the only changes required.

  4. Testing Done:

image

image

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels Jun 19, 2024
@github-actions github-actions bot added the v4 PRs for v4 label Jun 19, 2024
@hjoaquim hjoaquim added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit 826cbcd Jun 20, 2024
9 checks passed
@hjoaquim hjoaquim deleted the hotfix/fix-chart branch June 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @hjoaquim