Feature/apache beam samples #6653
Conversation
|
This is cool, thanks for the PR. I still need to do my homework to be able to fully test drive this puppy, so correct me if I'm wrong, I believe we can simplify the requirements to just |
|
Yes that is right..I just wanted to get whole obb to make sure code works
Rgds
…On Fri, 6 Sept 2024, 04:46 Danglewood, ***@***.***> wrote:
This is cool, thanks for the PR. I still need to do my homework to be able
to fully test drive this puppy, so correct me if I'm wrong, I believe we
can simplify the requirements to just openbb-yfinance, and we wouldn't
even need a version number. Can you confirm? You shouldn't have to change
any code for that, and it will shrink the overall footprint of the
environment.
—
Reply to this email directly, view it on GitHub
<#6653 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACPNCDVJMJBBXP4DRHAFDX3ZVEQP3AVCNFSM6AAAAABNV3YHCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZTGE3TSMJZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| @@ -0,0 +1,49 @@ | |||
| import unittest | |||
| import os | |||
| # You need to create a Conda environment (or a virtual env) using requirements.txt in this directory | ||
| # The script exercise 3 OBB endpoints, all of which require no credentials | ||
| # Run the test from the main directory | ||
| (obb-dataflow) C:\Users\Marco And Sofia\tmp\OBBDataflowSample>python -m unittest discover |
There was a problem hiding this comment.
Path here should be /tests.
Does the discover argument do something in Windows? On Mac, I get:
WARNING:apache_beam.options.pipeline_options:Discarding unparseable args: ['discover']
There was a problem hiding this comment.
pytests on windows, with discover, automatically find the unit test,. its just me being lazy and wanted to keep setup as minimal as possible, i'll amend instr
| @@ -0,0 +1,2 @@ | |||
| apache-beam | |||
| openbb==4.3.1 | |||
There was a problem hiding this comment.
Let's just make this, openbb-yfinance. Beam is a pretty heavy package by itself, and we don't need any of the router/app logic to run the sample.
| @@ -0,0 +1,13 @@ | |||
| #### Obb Dataflow sample | |||
There was a problem hiding this comment.
Please rename this file as a .md Markdown file. The First line is made a title with a single #.
Obb -> OBB.
sample -> Sample
|
|
||
|
|
||
| This is a sample how to invoke OBB fetchers in an Apache Beam pipeline. (GCP dataflow is build on Apache Beam) | ||
| -- Pre-requisite |
There was a problem hiding this comment.
For Markdown, we'll convert -- to ##. The items below get formatted as a bullet-point list by swapping # for -.
If you have a handy link to one of their quick start guides, let's include it here.
|
Closing because reopened as #6679 |
Pull Request Template for OpenBB Developers
Title:
Why? (1-3 sentences or a bullet point list):
What? (1-3 sentences or a bullet point list):
Impact (1-2 sentences or a bullet point list):
-N.A
Testing Done: