Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Bar Chart Fixes #6667

Merged
merged 1 commit into from
Sep 15, 2024
Merged

[BugFix] Bar Chart Fixes #6667

merged 1 commit into from
Sep 15, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Bar charts in Jupyter were always being set as "overlay" every time figure.show() was run.

    • hovertemplate and width were inaccessible from the bar_kwargs entry in the Generic Charts because those values were defined by default.

  2. What?:

    • Removes the lines that updated the figure layout as "overlay" when isatty was False.
    • Prioritizes the user-supplied hovertemplate and width in openbb_charting.charts.generic_charts.bar_chart so that multiple values are not sent to the params.
  3. Impact:

    • More better.
  4. Testing Done:

Before:
Screenshot 2024-09-10 at 8 07 53 PM

After:
Screenshot 2024-09-10 at 8 09 07 PM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels Sep 11, 2024
@github-actions github-actions bot added the v4 PRs for v4 label Sep 11, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Sep 15, 2024
Merged via the queue into develop with commit 77e22cc Sep 15, 2024
12 checks passed
@IgorWounds IgorWounds deleted the bugfix/some-chart-bugs branch September 26, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants