-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Use __alias_dict__
instead of Field(alias) for data fields.
#6673
Conversation
@andrewkenreich @tehcoderer please take a look at this one to see if there are any changes introduced here are breaking for you. |
@@ -29,12 +29,12 @@ class IntrinioShareStatisticsData(ShareStatisticsData): | |||
|
|||
__alias_dict__ = { | |||
"outstanding_shares": "weightedavebasicdilutedsharesos", | |||
"adjusted_outstanding_shares": "adjweightedavebasicdilutedsharesos", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are actually doing this already on our end, so this is good |
Why?:
Field(alias='someAlias')
and will end up labeling the Field as the Alias unless we use__alias_dict__
.What?:
Field
to__alias_dict__
Impact:
openapi.json
Testing Done: