Filter .tty serial ports in Networking for Mac users (Issue #1097) #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got an error "W_Networking.pde:182:0:182:0: cannot convert from element type SerialPort to String". Till then converting this to a draft pull request |
|
Error fixed. Was a silly miss of using String type iterator in for loop instead of the SerialPort. |
|
Working! |
retiutut
reviewed
Jun 6, 2023
| @@ -154,7 +154,9 @@ class W_Networking extends Widget { | |||
| protocolMode = "UDP"; //Set Default to UDP | |||
| protocolIndex = 2; //Set Default to UDP | |||
| addDropdown("Protocol", "Protocol", Arrays.asList(settings.nwProtocolArray), protocolIndex); | |||
| comPorts = new ArrayList<String>(Arrays.asList(processing.serial.Serial.list())); | |||
| // comPorts = new ArrayList<String>(Arrays.asList(processing.serial.Serial.list())); | |||
There was a problem hiding this comment.
This old line of code should be removed, but I'm about to start a major refactor of this class and I'll take care of it.
retiutut
approved these changes
Jun 6, 2023
|
Thanks for this PR! Tested and approved. Merging, and then after this I'll add this is an item in the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new method getCuCommPorts() to W_Networking.pde.
The method filters out .tty ports from the SerialPort library for Mac users and returns the results as a LinkedList
This method is called to store the result as an ArrayList in comPorts, which is then fed to the dropdown.
These changes are made to resolve Issue #1097 as recommended changes are made in a branch "networking_filter_serial_ports" based off the "development" branch.