Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate comments in Chinese to English for broader users #123

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

JackieQi
Copy link
Contributor

@JackieQi JackieQi commented Oct 27, 2023

Changed most Chinese comments to English. But also changed the code format of some files as side effect. It seems there is no code convention for this project.

🤔 What is the nature of this change? / 这个变动的性质是?

  • Code style optimization / 代码风格优化
  • Website, documentation, demo improvements / 网站、文档、Demo 改进
  • Refactor code or style / 重构代码或样式

📝 Changelog / 更新日志

No changes for the user side.

Changed most chinese comments to english. But also changed the code format of some files as side effect.
It seems there is no code convention for this project.
Copy link
Collaborator

@Umpire2018 Umpire2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to accomplish two things: first, it uses an IDE or code optimization tool to improve the code style, and second, it translates the comments from Chinese to English.

But I think these two changes should be split into two separate PRs to maintain atomicity because in my opinion, changing the code style is considered a breaking change.

I'm just curious how a complete translation is achieved. Do you have any tools to accomplish it quickly?

@kushal34712 kushal34712 mentioned this pull request Oct 27, 2023
10 tasks
@JackieQi
Copy link
Contributor Author

JackieQi commented Oct 27, 2023

@Umpire2018

This PR seems to accomplish two things: first, it uses an IDE or code optimization tool to improve the code style, and second, it translates the comments from Chinese to English.

But I think these two changes should be split into two separate PRs to maintain atomicity because in my opinion, changing the code style is considered a breaking change.

I agree. This code formatting is a side effect. I can disable and try again.

I'm just curious how a complete translation is achieved. Do you have any tools to accomplish it quickly?

You can do a search with regular expression in visual studio code.
use this ^.*[一-龥]
It will list all Chinese in the project. You can see i didn't change all because for some of them I don't have enough context

@Techuuu Techuuu mentioned this pull request Oct 28, 2023
8 tasks
@Lodaresole Lodaresole mentioned this pull request Oct 28, 2023
1 task
@Abhishekgupta204 Abhishekgupta204 mentioned this pull request Oct 30, 2023
10 tasks
@Umpire2018 Umpire2018 merged commit 6bea4d0 into OpenBMB:main Nov 3, 2023
@liyc-sys liyc-sys mentioned this pull request Nov 6, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants