Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign the Layout viewer dialog #145

Merged
merged 1 commit into from
May 2, 2020
Merged

Redesign the Layout viewer dialog #145

merged 1 commit into from
May 2, 2020

Conversation

mominul
Copy link
Member

@mominul mominul commented May 2, 2020

  • Layout viewer is now resizable.
  • Window contents dynamically resize along with the dialog.
  • Removed the unimplemented Zooming buttons.
  • View buttons dynamically enable itself with respect to the selected dialog.
  • About Layout is now simply a button with an icon.
  • Layout Viewer now handles layout without an image gracefully.

NewLayoutAvro
NewLayoutJatiya

Closes #115

@mominul mominul requested a review from Adyel May 2, 2020 16:35
Adyel
Adyel approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@Adyel Adyel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😃 👍

@mominul mominul merged commit d2a2c70 into master May 2, 2020
@mominul mominul deleted the layout_dialog branch August 25, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adyel Adyel Adyel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign the Layout viewer dialog
2 participants
@mominul @Adyel