Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/e2e] attempt to remove flake on backgroundTask test (#7378) #7861

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jul 30, 2024

Proposed changes

  • Force reload page when the expect fails one time (kind of retry = 1)

Related issues

   [chromium] › backgroundTask/backgroundTask.spec.ts:24:5 › Verify background tasks execution ───
    
    Error: Timed out 60000ms waiting for expect(locator).toBeVisible()
    
    Locator: getByText('2 entitie(s)')
    Expected: visible
    Received: <element(s) not found>
    Call log:
    
    - expect.toBeVisible with timeout 60000ms
    - waiting for getByText('2 entitie(s)')

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@aHenryJard aHenryJard changed the title Playing with flakes [frontend/e2e] Playing with flakes Jul 30, 2024
@aHenryJard aHenryJard changed the title [frontend/e2e] Playing with flakes [frontend/e2e] Playing with flakes (#7378) Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (9e724d2) to head (fc4d61b).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7861      +/-   ##
==========================================
+ Coverage   67.38%   68.07%   +0.68%     
==========================================
  Files         570      570              
  Lines       70454    70609     +155     
  Branches     5949     6249     +300     
==========================================
+ Hits        47478    48067     +589     
+ Misses      22976    22542     -434     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard
Copy link
Member Author

aHenryJard commented Aug 1, 2024

Builld1 : all in success

@aHenryJard aHenryJard changed the title [frontend/e2e] Playing with flakes (#7378) [frontend/e2e] attempt to remove flake on backgroundTask test (#7378) Aug 1, 2024
@aHenryJard
Copy link
Member Author

All green again. Trying a third time.

@aHenryJard aHenryJard marked this pull request as ready for review August 1, 2024 13:53
@aHenryJard aHenryJard merged commit cf56da5 into master Aug 1, 2024
5 checks passed
@SamuelHassine SamuelHassine deleted the issue/7378-deflake-tasks branch August 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants