Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Domain observable checker is incorrect (#7620) #8768

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Change the regex to also accept dots on subdomain

Related issues

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Oct 24, 2024
@SarahBocognano SarahBocognano self-assigned this Oct 24, 2024
@SouadHadjiat
Copy link
Member

unit tests are failing on this PR, also could you add corresponding unit test for the usecase we are fixing ?

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.95%. Comparing base (e17b1ed) to head (49d07c7).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8768      +/-   ##
==========================================
+ Coverage   66.29%   66.95%   +0.65%     
==========================================
  Files         597      597              
  Lines       60958    60983      +25     
  Branches     6261     6701     +440     
==========================================
+ Hits        40414    40831     +417     
+ Misses      20544    20152     -392     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants