Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Domain observable with hyphen/dash is incorrectly rejected (#8927) #8929

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Add hyphen/dash in regex checker

Related issues

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Nov 6, 2024
@SarahBocognano SarahBocognano self-assigned this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.30%. Comparing base (ad7bbb2) to head (a57a294).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8929      +/-   ##
==========================================
+ Coverage   66.29%   66.30%   +0.01%     
==========================================
  Files         597      597              
  Lines       61033    61033              
  Branches     6276     6277       +1     
==========================================
+ Hits        40460    40468       +8     
+ Misses      20573    20565       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano merged commit 89a965c into master Nov 7, 2024
6 checks passed
@SarahBocognano SarahBocognano deleted the issue/8927 branch November 7, 2024 09:51
@romain-filigran romain-filigran modified the milestone: Release 6.3.11 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants