Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvcsController unable to set certain channel values from child evcs component #1197

Closed
marcelheim opened this issue Aug 6, 2020 · 1 comment
Assignees

Comments

@marcelheim
Copy link

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Bug description or desired functionality.

Version: 2020.16.0 (Release)
Afftected component: io.openems.edge.controller.evcs
Source: EvcsController.java after commit 641d048

Description

Channels SET_ENERGY_LIMIT, SET_CHARGE_POWER_REQUEST, SET_CHARGE_POWER_LIMIT aren't set properly by methods setEnergyLimit(), setChargePowerRequest() and setChargePowerLimit() in used evcs component

Example code from EvcsController.java

if (!config.enabledCharging()) {
	evcs.setChargePowerLimit(0);
	return;
}

Possible fix

Call internal set funtion

if (!config.enabledCharging()) {
	evcs._setChargePowerLimit(0);
	return;
}
@sebastianasen
Copy link
Contributor

Hallo @marcelheim,
thank you for creating this issue.

Do you use the EvcsController in combination with an EvcsCluster?
Only here, i found the bug that an old requested charge power is still preset.

Because of that, the cluster is setting also the setChargePowerLimit (to the old value).
This will be fixed in the next pull request wich i will mention in here.


For your information:
The _setChargePowerLimit will set the "value" of the Channel "SetChargePowerLimit". This value is only used for displaying the current target we sent.

The setChargePowerLimit will set per defenition the "write value" of the Channel.
In every Chargingstation i will react on the WriteValue and will reset it afterwards. Only that Value will be forwarded to the chargingstation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants