-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further development and rework of the EVCS (Electric Vehicle Charging Station) components #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added unknown state in the UI.
# Conflicts: # ui/src/app/edge/live/evcs/modal/modal.page.ts # ui/src/app/shared/translate/es.ts # ui/src/app/shared/translate/nl.ts
Because of that, every ManagedEvcs impl. needs a the current reference of the EvcsPowerComponent, to have the global ramp filter and in the future other things of the EvcsPower Interface. Initial rework of the EvcsCluster. Small format changes.
…n the config instead of checking the _Property Channels.
… Evcs Cluster components.
…ging station needs and adapted the tests
# Conflicts: # io.openems.edge.ess.core/src/io/openems/edge/ess/core/power/PowerComponent.java
…that value of the maximumum for calculation, but the sent charge power will be like before.
…otal energy value. Adjustments to the ABL implementation
… discharge power" of the ess, to avoid certain jumps to zero, if the essSoc gets lower.
# Conflicts: # io.openems.edge.controller.evcs/src/io/openems/edge/controller/evcs/EvcsController.java # io.openems.edge.controller.evcs/test/io/openems/edge/controller/evcs/EvcsControllerTest.java # io.openems.edge.controller.evcs/test/io/openems/edge/controller/evcs/MyConfig.java # io.openems.edge.evcs.cluster/test/io/openems/edge/evcs/cluster/EvcsClusterTest.java # io.openems.edge.evcs.cluster/test/io/openems/edge/evcs/cluster/MyConfigPeakShaving.java
…RGY). Set the total energy and session energy depending on one energy value form the chargingstation (depending on the chargingstation we get the total or the session energy).
…tments # Conflicts: # io.openems.edge.simulator/src/io/openems/edge/simulator/evcs/SimulatedEvcs.java
sfeilmeier
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. It's not perfect, but a big improvement to 'develop'. Thanks!
* <li>Unit: W | ||
* </ul> | ||
*/ | ||
SET_CHARGE_POWER_LIMIT_WITH_PID(new IntegerDoc() // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not actually a PID filter, so it's a bit misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate a ramp filter, used primary by EVCS's, instead of using a PID Filter for the charge power:
Wrote new tests for EvcsController and EvcsCluster
Substantial changes in the EvcsCluster:
charge power will be like before
(Some cars are reacting like this: setPower: 22 kW -> chargedPower: 11kW, setPower: 11kW -> chargedPower 7 kW, ... )
zero, if the essSoc gets lower. In the future, this should be handled by each battery itself.
General changes in the energy calculation of OCPP EVCS's:
Now we are calculating the always the other value, depending on the given
Fixed Issue EvcsController unable to set certain channel values from child evcs component #1197 (Send also a chargePowerRequest of 0 if charging is disabled)
Small bug fixes