-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GoodWe battery remote control improvements. #1201
Conversation
Is the logic itself working already - e.g. in self-consumption optimization mode? If not, I believe it makes more sense to review the code later. |
# Conflicts: # io.openems.edge.goodwe.et/src/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImpl.java
io.openems.edge.goodwe.et/src/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImpl.java
Outdated
Show resolved
Hide resolved
io.openems.edge.goodwe.et/src/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImpl.java
Outdated
Show resolved
Hide resolved
io.openems.edge.goodwe.et/src/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImpl.java
Outdated
Show resolved
Hide resolved
io.openems.edge.goodwe.et/src/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@venu-sagar Unfortunately I am not able to finish the pull-request without your input. I have some problems in understanding what happend to the scenarios we defined.
Before we merge to develop
we will also have to remove all the System.out.println
lines
io.openems.edge.goodwe.et/src/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImpl.java
Outdated
Show resolved
Hide resolved
io.openems.edge.goodwe.et/src/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImpl.java
Outdated
Show resolved
Hide resolved
...enems.edge.goodwe.et/test/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImplTest.java
Outdated
Show resolved
Hide resolved
- Add Channel "GoodweType": holds automatically detected information if it is a ET or BT - Add special handling for BT - Rename State-Machine States for BT and ET
this will break existing configurations!
# Conflicts: # io.openems.edge.goodwe.et/src/io/openems/edge/goodwe/et/ess/GoodWeEtBatteryInverterImpl.java
Added configurable variable Battery max charging/discharging power. The battery's allowed charge and discharge power auto-adjusts based on this value.
Added auto adjustable allowed charge and discharge value based on the state of Charge value.