Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoodWe battery remote control improvements. #1201

Merged
merged 26 commits into from
Nov 10, 2020
Merged

Conversation

venu-sagar
Copy link
Contributor

Added configurable variable Battery max charging/discharging power. The battery's allowed charge and discharge power auto-adjusts based on this value.

Added auto adjustable allowed charge and discharge value based on the state of Charge value.

@sfeilmeier
Copy link
Contributor

Is the logic itself working already - e.g. in self-consumption optimization mode? If not, I believe it makes more sense to review the code later.

@sfeilmeier sfeilmeier removed their request for review August 19, 2020 19:03
@venu-sagar venu-sagar marked this pull request as ready for review October 20, 2020 09:08
Copy link
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@venu-sagar Unfortunately I am not able to finish the pull-request without your input. I have some problems in understanding what happend to the scenarios we defined.

Before we merge to develop we will also have to remove all the System.out.println lines

venu-sagar and others added 6 commits October 22, 2020 16:51
- Add Channel "GoodweType": holds automatically detected information if it is a ET or BT
- Add special handling for BT
- Rename State-Machine States for BT and ET
this will break existing configurations!
@sfeilmeier sfeilmeier merged commit 010d089 into develop Nov 10, 2020
@sfeilmeier sfeilmeier deleted the feature/GoodWeFix branch November 10, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants