Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to log4j2 #1686

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Switch to log4j2 #1686

merged 3 commits into from
Dec 21, 2021

Conversation

OlafSeng
Copy link
Contributor

Hi Stefan,

as discussed in the community, I have created a merge request regarding my Log4J2 changes.
The idea is to use a PaxOsgiappender, as described here.

I was able to test the changes successfully for the OpenEMS edge running on my local machine. However, the configuration file in 'pax/logging.config' is not updated when I start the backend locally.
Unfortunately, I was not able to find out why, but the problem already existed before applying my changes, so it might be an issue with the development branch.

Originally, I have developed these changes for a slightly older version of OpenEMS which still runs on Java 8. On this version, both OpenEMS Backend and Edge are working fine.

Regards,

Olaf

@sfeilmeier
Copy link
Contributor

Hi Olaf,

thank you very much for your contribution! I fixed updating of the configuration files for Edge and Backend. It works reliably here on my machine.

Could you give it a final test so that we can merge it?

Regards,
Stefan

@OlafSeng
Copy link
Contributor Author

Hi Stefan,

thank you for fixing the configuration. Now it works reliably on my machine as well, so I would say we can merge the changes.

Funny thing is, at first it didn't work. But after I switched from '16.0.1.j9-adpt' to '17.0.1.12.1-amzn' and completely rebuilt the application, everything is fine.

Regards,

Olaf

@sfeilmeier sfeilmeier merged commit edb1589 into OpenEMS:develop Dec 21, 2021
@sfeilmeier
Copy link
Contributor

Thanks for checking. Strange... sometimes the build behaviour is weird. I usually rely on my prepare-commit.sh script for the final check. (https://github.com/OpenEMS/openems/blob/develop/tools/prepare-commit.sh)

Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants